]> asedeno.scripts.mit.edu Git - linux.git/commit
power: supply: axp288_charger: Fix unchecked return value
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 18 Mar 2019 16:14:39 +0000 (11:14 -0500)
committerSebastian Reichel <sre@kernel.org>
Fri, 5 Apr 2019 14:03:44 +0000 (16:03 +0200)
commitc3422ad5f84a66739ec6a37251ca27638c85b6be
tree5ccf10e2bcbfd4452b0a01ec2346cda0effdaa13
parentf0459fe14713081294b18bf1243f8de459814131
power: supply: axp288_charger: Fix unchecked return value

Currently there is no check on platform_get_irq() return value
in case it fails, hence never actually reporting any errors and
causing unexpected behavior when using such value as argument
for function regmap_irq_get_virq().

Fix this by adding a proper check, a message reporting any errors
and returning *pirq*

Addresses-Coverity-ID: 1443940 ("Improper use of negative value")
Fixes: 843735b788a4 ("power: axp288_charger: axp288 charger driver")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/axp288_charger.c