]> asedeno.scripts.mit.edu Git - linux.git/commit
driver core: Move async_synchronize_full call
authorAlexander Duyck <alexander.h.duyck@linux.intel.com>
Thu, 29 Nov 2018 00:32:11 +0000 (16:32 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 15:00:43 +0000 (16:00 +0100)
commitc37d721c68ad88925ba0e72f6e14acb829a8c6bb
treeaec913e20edb678f7751bcc1a036d039fefd7fb7
parent99fef587ff98894426d9bf1f5b7336345052d4b3
driver core: Move async_synchronize_full call

Move the async_synchronize_full call out of __device_release_driver and
into driver_detach.

The idea behind this is that the async_synchronize_full call will only
guarantee that any existing async operations are flushed. This doesn't do
anything to guarantee that a hotplug event that may occur while we are
doing the release of the driver will not be asynchronously scheduled.

By moving this into the driver_detach path we can avoid potential deadlocks
as we aren't holding the device lock at this point and we should not have
the driver we want to flush loaded so the flush will take care of any
asynchronous events the driver we are detaching might have scheduled.

Fixes: 765230b5f084 ("driver-core: add asynchronous probing support for drivers")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/dd.c