]> asedeno.scripts.mit.edu Git - linux.git/commit
vfio-ccw: Fix the conversion of Format-0 CCWs to Format-1
authorEric Farman <farman@linux.ibm.com>
Tue, 2 Jul 2019 18:09:28 +0000 (20:09 +0200)
committerCornelia Huck <cohuck@redhat.com>
Fri, 5 Jul 2019 05:58:53 +0000 (07:58 +0200)
commitc382cbc6dbf513d73cf896ad43a3789ad42c2e2f
tree90185383628daf3550077cebaabf664033b8d80a
parent05f31e3bf6b34fe6e4922868d132f6455f81d5bf
vfio-ccw: Fix the conversion of Format-0 CCWs to Format-1

When processing Format-0 CCWs, we use the "len" variable as the
number of CCWs to convert to Format-1.  But that variable
contains zero here, and is not a meaningful CCW count until
ccwchain_calc_length() returns.  Since that routine requires and
expects Format-1 CCWs to identify the chaining behavior, the
format conversion must be done first.

Convert the 2KB we copied even if it's more than we need.

Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")
Reported-by: Farhan Ali <alifm@linux.ibm.com>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20190702180928.18113-1-farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
drivers/s390/cio/vfio_ccw_cp.c