]> asedeno.scripts.mit.edu Git - linux.git/commit
net: ife: drop include of module.h from net/ife.h
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 21 Apr 2019 03:29:43 +0000 (23:29 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Apr 2019 04:50:53 +0000 (21:50 -0700)
commitc517796ea91d11dd3f0ae7ff61a12fe5d4941eb0
tree17bca2000f734cadbb820cecefc5049e5ff8a62d
parenta79eda3aaf30bc73752487fff5160cf67e99e313
net: ife: drop include of module.h from net/ife.h

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

There doesn't appear to be anything in net/ife.h that is module
related, and build coverage doesn't appear to show any other
files/drivers relying implicitly on getting it from here.

So it appears we are simply free to just remove it in this case.

Cc: Yotam Gigi <yotam.gi@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ife.h