]> asedeno.scripts.mit.edu Git - linux.git/commit
ALSA: seq: oss: Fix Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 20 Mar 2019 23:42:01 +0000 (18:42 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 21 Mar 2019 12:23:51 +0000 (13:23 +0100)
commitc709f14f0616482b67f9fbcb965e1493a03ff30b
tree2cfa6b64ad0a88d95aea65c6c2d13fdb8face6da
parent2b1d9c8f87235f593826b9cf46ec10247741fff9
ALSA: seq: oss: Fix Spectre v1 vulnerability

dev is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

sound/core/seq/oss/seq_oss_synth.c:626 snd_seq_oss_synth_make_info() warn: potential spectre issue 'dp->synths' [w] (local cap)

Fix this by sanitizing dev before using it to index dp->synths.

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://lore.kernel.org/lkml/20180423164740.GY17484@dhcp22.suse.cz/

Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/oss/seq_oss_synth.c