]> asedeno.scripts.mit.edu Git - linux.git/commit
media: usbvision: Fix invalid accesses after device disconnect
authorAlan Stern <stern@rowland.harvard.edu>
Mon, 7 Oct 2019 15:09:04 +0000 (12:09 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 10 Oct 2019 10:22:06 +0000 (07:22 -0300)
commitc7a191464078262bf799136317c95824e26a222b
tree8faf2a70d7adf38c6fdbc60aa1d2c60f1457e8b2
parent59251a8be3c258c6ce59dcce703ce440a4e03b82
media: usbvision: Fix invalid accesses after device disconnect

The syzbot fuzzer found two invalid-access bugs in the usbvision
driver.  These bugs occur when userspace keeps the device file open
after the device has been disconnected and usbvision_disconnect() has
set usbvision->dev to NULL:

When the device file is closed, usbvision_radio_close() tries
to issue a usb_set_interface() call, passing the NULL pointer
as its first argument.

If userspace performs a querycap ioctl call, vidioc_querycap()
calls usb_make_path() with the same NULL pointer.

This patch fixes the problems by making the appropriate tests
beforehand.  Note that vidioc_querycap() is protected by
usbvision->v4l2_lock, acquired in a higher layer of the V4L2
subsystem.

Reported-and-tested-by: syzbot+7fa38a608b1075dfd634@syzkaller.appspotmail.com
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/usbvision/usbvision-video.c