]> asedeno.scripts.mit.edu Git - linux.git/commit
net: rework SIOCGSTAMP ioctl handling
authorArnd Bergmann <arnd@arndb.de>
Wed, 17 Apr 2019 20:51:48 +0000 (22:51 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Apr 2019 21:07:40 +0000 (14:07 -0700)
commitc7cbdbf29f488a19982cd9f4a109887f18028bbb
tree74b39321c14b93411eda0939683dc9b8b713717b
parent1ab839281cf72476988901a2606378d76530f99c
net: rework SIOCGSTAMP ioctl handling

The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
socket protocol handlers, and all of those end up calling the same
sock_get_timestamp()/sock_get_timestampns() helper functions, which
results in a lot of duplicate code.

With the introduction of 64-bit time_t on 32-bit architectures, this
gets worse, as we then need four different ioctl commands in each
socket protocol implementation.

To simplify that, let's add a new .gettstamp() operation in
struct proto_ops, and move ioctl implementation into the common
sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
through.

We can reuse the sock_get_timestamp() implementation, but generalize
it so it can deal with both native and compat mode, as well as
timeval and timespec structures.

Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2=WDCp82ys8eUT+A@mail.gmail.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
33 files changed:
include/linux/net.h
include/net/compat.h
include/net/sock.h
net/appletalk/ddp.c
net/atm/ioctl.c
net/atm/pvc.c
net/atm/svc.c
net/ax25/af_ax25.c
net/bluetooth/af_bluetooth.c
net/bluetooth/l2cap_sock.c
net/bluetooth/rfcomm/sock.c
net/bluetooth/sco.c
net/can/af_can.c
net/can/bcm.c
net/can/raw.c
net/compat.c
net/core/sock.c
net/dccp/ipv4.c
net/dccp/ipv6.c
net/ieee802154/socket.c
net/ipv4/af_inet.c
net/ipv6/af_inet6.c
net/ipv6/raw.c
net/l2tp/l2tp_ip.c
net/l2tp/l2tp_ip6.c
net/netrom/af_netrom.c
net/packet/af_packet.c
net/qrtr/qrtr.c
net/rose/af_rose.c
net/sctp/ipv6.c
net/sctp/protocol.c
net/socket.c
net/x25/af_x25.c