]> asedeno.scripts.mit.edu Git - linux.git/commit
spi: bcm2835aux: remove dangerous uncontrolled read of fifo
authorMartin Sperl <kernel@martin.sperl.org>
Sat, 30 Mar 2019 09:30:59 +0000 (09:30 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 3 Apr 2019 04:31:06 +0000 (11:31 +0700)
commitc7de8500fd8ecbb544846dd5f11dca578c3777e1
tree1de57f27eaf008b47135c316e2c1e289f45337a2
parent7188a6f0eee3f1fae5d826cfc6d569657ff950ec
spi: bcm2835aux: remove dangerous uncontrolled read of fifo

This read of the fifo is a potential candidate for a race condition
as the spi transfer is not necessarily finished and so can lead to
an early read of the fifo that still misses data.

So it has been removed.

Fixes: 1ea29b39f4c812ec ("spi: bcm2835aux: add bcm2835 auxiliary spi device...")
Suggested-by: Hubert Denkmair <h.denkmair@intence.de>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm2835aux.c