]> asedeno.scripts.mit.edu Git - linux.git/commit
remoteproc: use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 30 Aug 2019 15:14:06 +0000 (10:14 -0500)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 20 Jan 2020 18:50:54 +0000 (10:50 -0800)
commitc87846571587f1c2217f16104586fd33216fc9e0
tree9c4a8f82787aa55709ea2f1da51bb919621c5cf9
parenta8f40111d184098cd2b3dc0c7170c42250a5fa09
remoteproc: use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct fw_rsc_vdev {
...
        struct fw_rsc_vdev_vring vring[0];
} __packed;

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(*rsc) + rsc->num_of_vrings * sizeof(struct fw_rsc_vdev_vring)

with:

struct_size(rsc, vring, rsc->num_of_vrings)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20190830151406.GA23274@embeddedor
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/remoteproc_core.c