]> asedeno.scripts.mit.edu Git - linux.git/commit
tracing: Check keys for variable references in expressions too
authorTom Zanussi <tom.zanussi@linux.intel.com>
Thu, 18 Apr 2019 15:18:51 +0000 (10:18 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 21 May 2019 16:46:32 +0000 (12:46 -0400)
commitc8d94a1878342fdffedaaf15201d951dfc147065
treea970fca16b97110bd648f998d4fb7aeb21a5994e
parent55267c88c003a3648567beae7c90512d3e2ab15e
tracing: Check keys for variable references in expressions too

There's an existing check for variable references in keys, but it
doesn't go far enough.  It checks whether a key field is a variable
reference but doesn't check whether it's an expression containing
variable references, which can cause the same problems for callers.

Use the existing field_has_hist_vars() function rather than a direct
top-level flag check to catch all possible variable references.

Link: http://lkml.kernel.org/r/e8c3d3d53db5ca90ceea5a46e5413103a6902fc7.1555597045.git.tom.zanussi@linux.intel.com
Cc: stable@vger.kernel.org
Fixes: 067fe038e70f6 ("tracing: Add variable reference handling to hist triggers")
Reported-by: Vincent Bernat <vincent@bernat.ch>
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c