]> asedeno.scripts.mit.edu Git - linux.git/commit
vfio-ccw: Fix misleading comment when setting orb.cmd.c64
authorFarhan Ali <alifm@linux.ibm.com>
Thu, 11 Jul 2019 14:28:51 +0000 (10:28 -0400)
committerCornelia Huck <cohuck@redhat.com>
Mon, 15 Jul 2019 12:14:33 +0000 (14:14 +0200)
commitc9f597a4d6d7a01590571291f659a2f146111e34
tree48f83da77ea7aaaeb20ddfc6120cb47607ddf124
parent9a159190414d461fdac7ae5bb749c2d532b35419
vfio-ccw: Fix misleading comment when setting orb.cmd.c64

The comment is misleading because it tells us that
we should set orb.cmd.c64 before calling ccwchain_calc_length,
otherwise the function ccwchain_calc_length would return an
error. This is not completely accurate.

We want to allow an orb without cmd.c64, and this is fine
as long as the channel program does not use IDALs. But we do
want to reject any channel program that uses IDALs and does
not set the flag, which is what we do in ccwchain_calc_length.

After we have done the ccw processing, we need to set cmd.c64,
as we use IDALs for all translated channel programs.

Also for better code readability let's move the setting of
cmd.c64 within the non error path.

Fixes: fb9e7880af35 ("vfio: ccw: push down unsupported IDA check")
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <f68636106aef0faeb6ce9712584d102d1b315ff8.1562854091.git.alifm@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
drivers/s390/cio/vfio_ccw_cp.c