]> asedeno.scripts.mit.edu Git - linux.git/commit
leds: ktd2692: avoid harmless maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 25 Jan 2017 22:22:36 +0000 (23:22 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 26 Jan 2017 20:16:38 +0000 (21:16 +0100)
commitcbe99c538d1776009e8710755bb6e726f7fffa9b
tree1f69e468ff6b04db290b00fb9b3f8fdd43027a97
parent4e552c8cb5bc9137e67e035bab8df6dddbca7384
leds: ktd2692: avoid harmless maybe-uninitialized warning

gcc gets confused about the control flow in ktd2692_parse_dt(), causing
it to warn about what seems like a potential bug:

drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is fine, and slightly reworking it in an equivalent way lets
gcc figure that out too, which gets rid of the warning.

Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-ktd2692.c