]> asedeno.scripts.mit.edu Git - linux.git/commit
[media] v4l: xilinx-tpg: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 25 Oct 2015 13:57:05 +0000 (11:57 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 19 Nov 2015 11:26:55 +0000 (09:26 -0200)
commitcc331d37fe3a7b6db086721b0e9cac1ea2e03ebf
treee24ea57603bafa2a87335cb68fcca6697b898333
parentb771852270499d760825ebad894498b8059355a4
[media] v4l: xilinx-tpg: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/xilinx/xilinx-tpg.c