]> asedeno.scripts.mit.edu Git - linux.git/commit
sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Fri, 5 Jan 2018 13:17:17 +0000 (11:17 -0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Jan 2018 19:19:13 +0000 (14:19 -0500)
commitcc35c3d1edf7a8373a1a5daa80a912dec96a9cd5
tree2badea82208ce8d5e37ee152ac4f6aeff254db95
parentb707fda2df4070785d0fa8a278aa13944c5f51f8
sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled

Currently, if PMTU discovery is disabled on a given transport, but the
configured value is higher than the actual PMTU, it is likely that we
will get some icmp Frag Needed. The issue is, if PMTU discovery is
disabled, we won't update the information and will issue a
retransmission immediately, which may very well trigger another ICMP,
and another retransmission, leading to a loop.

The fix is to simply not trigger immediate retransmissions if PMTU
discovery is disabled on the given transport.

Changes from v2:
- updated stale comment, noticed by Xin Long

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/input.c