]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/8xx: Fix possible device node reference leak
authorWen Yang <wen.yang99@zte.com.cn>
Tue, 26 Mar 2019 10:29:51 +0000 (18:29 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Sat, 20 Apr 2019 12:02:35 +0000 (22:02 +1000)
commitcc76404feaed597bb4f5234d34d3f49e2d1139bf
tree44d7a02ed2d418b2a89c61911c8ff2b893649386
parent7f177f9810ada8ec2e8b378eddbe2d91fda79c9b
powerpc/8xx: Fix possible device node reference leak

The call to of_find_compatible_node() returns a node pointer with
refcount incremented thus it must be explicitly decremented after the
last usage.

irq_domain_add_linear() also calls of_node_get() to increase refcount,
so irq_domain() will not be affected when it is released.

Detected by coccinelle.

Fixes: a8db8cf0d894 ("irq_domain: Replace irq_alloc_host() with revmap-specific initializers")
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/8xx/pic.c