]> asedeno.scripts.mit.edu Git - linux.git/commit
pata_atiixp: Remove unnecessary parentheses
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 11 Sep 2018 21:43:38 +0000 (14:43 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 11 Sep 2018 22:56:46 +0000 (16:56 -0600)
commitce42c1768152277658d48196f144aa406a4ea52a
tree012c82e6a62c6cc76cac01f89eb25d305b71f676
parent20bdc376b427cb420836f39ee8f281ea85dbaeef
pata_atiixp: Remove unnecessary parentheses

Clang warns when more than one set of parentheses is used for a
single conditional statement:

drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
            ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
around the comparison to silence this warning
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
           ~             ^                              ~
drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
comparison into an assignment
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
                         ^~
                         =
1 warning generated.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/ata/pata_atiixp.c