]> asedeno.scripts.mit.edu Git - linux.git/commit
PCI/switchtec: Add Gen4 MRPC GAS access permission check
authorKelvin Cao <kelvin.cao@microchip.com>
Mon, 6 Jan 2020 19:03:35 +0000 (12:03 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 15 Jan 2020 17:00:39 +0000 (11:00 -0600)
commitce7c88600bf8ec0d12cf8e147907f96cd58eeb2e
treefb70df029e2a5eba8485505d199f138c4f626e42
parent4efa1d2e36976d7b26f2e67f4c838330fbc91299
PCI/switchtec: Add Gen4 MRPC GAS access permission check

Gen4 hardware provides new MRPC commands to read and write directly from
any address in the PCI BAR (which Microsemi refers to as GAS). Since
accessing BARs can be dangerous and break the driver, we don't want
unprivileged users to have this ability.

Therefore, require CAP_SYS_ADMIN for the local and remote GAS access MRPC
commands. Privileged processes will already have access to the BAR through
the sysfs resource file so this doesn't give userspace any capabilities it
didn't already have.

[logang@deltatee.com: rework commit message]
Link: https://lore.kernel.org/r/20200106190337.2428-11-logang@deltatee.com
Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/switch/switchtec.c
include/linux/switchtec.h