]> asedeno.scripts.mit.edu Git - linux.git/commit
MIPS: microMIPS: Fix decoding of swsp16 instruction
authorMatt Redfearn <matt.redfearn@imgtec.com>
Tue, 8 Aug 2017 12:22:33 +0000 (13:22 +0100)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 6 Sep 2017 11:20:25 +0000 (13:20 +0200)
commitcea8cd498f4f1c30ea27e3664b3c671e495c4fce
treef16e510564b485a6dffeab795cea7b103b34f7ce
parenta0ae2b08331a9882150618e0c81ea837e4a37ace
MIPS: microMIPS: Fix decoding of swsp16 instruction

When the immediate encoded in the instruction is accessed, it is sign
extended due to being a signed value being assigned to a signed integer.
The ISA specifies that this operation is an unsigned operation.
The sign extension leads us to incorrectly decode:

801e9c8e:       cbf1            sw      ra,68(sp)

As having an immediate of 1073741809.

Since the instruction format does not specify signed/unsigned, and this
is currently the only location to use this instuction format, change it
to an unsigned immediate.

Fixes: bb9bc4689b9c ("MIPS: Calculate microMIPS ra properly when unwinding the stack")
Suggested-by: Paul Burton <paul.burton@imgtec.com>
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Cc: Miodrag Dinic <miodrag.dinic@imgtec.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/16957/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/include/uapi/asm/inst.h
arch/mips/kernel/process.c