]> asedeno.scripts.mit.edu Git - linux.git/commit
tpm: Fix IRQ unwind ordering in TIS
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Wed, 27 Apr 2016 16:58:46 +0000 (10:58 -0600)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sat, 25 Jun 2016 14:26:35 +0000 (17:26 +0300)
commitced01b9ffc482d45b57d368a6382e498aa24f66a
tree0e5d553e7aca2bd91b7bc44d6a5dec1229268e87
parent7e1dc002c00b932dfefd9af05bdffa6f3986ad55
tpm: Fix IRQ unwind ordering in TIS

The devm for the IRQ was placed on the chip, not the pdev. This can
cause the irq to be still callable after the pdev has been cleaned up
(eg priv kfree'd).

Found by CONFIG_DEBUG_SHIRQ=y

Reported-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Fixes: 233a065e0cd0 ("tpm: Get rid of chip->pdev")
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis.c