]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: ti_usb_3410_5052: use irqsave() in USB's complete callback
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:14 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 13:26:18 +0000 (15:26 +0200)
commitcf83be24b2efc423f6869a155372e3694c12a558
tree37a5194865111c2a307399ab98d9b834309c6f62
parent5e02bfcf3f4f8c76c47718063d408c8a09d61bca
USB: serial: ti_usb_3410_5052: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ti_usb_3410_5052.c