]> asedeno.scripts.mit.edu Git - linux.git/commit
e1000e: start network tx queue only when link is up
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Wed, 17 Apr 2019 08:13:20 +0000 (11:13 +0300)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 28 May 2019 23:08:43 +0000 (16:08 -0700)
commitd17ba0f616a08f597d9348c372d89b8c0405ccf3
tree743301d3a876fa3356e2e648aef0f65b48b961f9
parentcaff422ea81e144842bc44bab408d85ac449377b
e1000e: start network tx queue only when link is up

Driver does not want to keep packets in Tx queue when link is lost.
But present code only reset NIC to flush them, but does not prevent
queuing new packets. Moreover reset sequence itself could generate
new packets via netconsole and NIC falls into endless reset loop.

This patch wakes Tx queue only when NIC is ready to send packets.

This is proper fix for problem addressed by commit 0f9e980bf5ee
("e1000e: fix cyclic resets at link up with active tx").

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
Tested-by: Joseph Yasi <joe.yasi@gmail.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c