]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct
authorHans de Goede <hdegoede@redhat.com>
Mon, 18 Nov 2019 15:51:32 +0000 (16:51 +0100)
committerHans de Goede <hdegoede@redhat.com>
Mon, 16 Dec 2019 11:13:18 +0000 (12:13 +0100)
commitd1fe276b5115f0d581c3cfe6154633b3547e8aab
tree58ad217d137fddcc301a036a9b5c6cc38f8c38eb
parent5b926617cdef41ce0696e09834991194b1759e28
drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct

Instead of only setting mode->specified on false on an early exit and
leaving e.g. mode->bpp_specified and mode->refresh_specified as is,
lets be consistent and just zero out the entire passed in struct at
the top of drm_mode_parse_command_line_for_connector()

Changes in v3:
-Drop "mode->specified = false;" line instead of the "return false;" (oops)
 This crasher was reported-by: kernel test robot <lkp@intel.com>

Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-11-hdegoede@redhat.com
drivers/gpu/drm/drm_modes.c