]> asedeno.scripts.mit.edu Git - linux.git/commit
fpga: Remove dev_err() usage after platform_get_irq()
authorStephen Boyd <swboyd@chromium.org>
Tue, 30 Jul 2019 18:15:14 +0000 (11:15 -0700)
committerMoritz Fischer <mdf@kernel.org>
Sat, 5 Oct 2019 01:57:16 +0000 (18:57 -0700)
commitd20c0da8b2020acaa107b42041c8da2bafed1910
tree4ef9ebf965ad48a75b66ece6678b59ea3293a43a
parent54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
fpga: Remove dev_err() usage after platform_get_irq()

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
drivers/fpga/zynq-fpga.c