]> asedeno.scripts.mit.edu Git - linux.git/commit
9p/net: Fix zero-copy path in the 9p virtio transport
authorChirantan Ekbote <chirantan@chromium.org>
Tue, 17 Jul 2018 00:35:29 +0000 (17:35 -0700)
committerDominique Martinet <dominique.martinet@cea.fr>
Mon, 13 Aug 2018 00:34:59 +0000 (09:34 +0900)
commitd28c756caee6e414d9ba367d0b92da24145af2a8
treefab71e301177f94c5353f1e05b5d7114090fc25c
parent2557d0c57c0c11af915d0d4d97402527958c0c01
9p/net: Fix zero-copy path in the 9p virtio transport

The zero-copy optimization when reading or writing large chunks of data
is quite useful.  However, the 9p messages created through the zero-copy
write path have an incorrect message size: it should be the size of the
header + size of the data being written but instead it's just the size
of the header.

This only works if the server ignores the size field of the message and
otherwise breaks the framing of the protocol. Fix this by re-writing the
message size field with the correct value.

Tested by running `dd if=/dev/zero of=out bs=4k count=1` inside a
virtio-9p mount.

Link: http://lkml.kernel.org/r/20180717003529.114368-1-chirantan@chromium.org
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Tested-by: Greg Kurz <groug@kaod.org>
Cc: Dylan Reid <dgreid@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
net/9p/trans_virtio.c