]> asedeno.scripts.mit.edu Git - linux.git/commit
hsr: fix don't prune the master node from the node_db
authorAndreas Oetken <andreas.oetken@siemens.com>
Thu, 23 May 2019 11:57:14 +0000 (13:57 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 May 2019 16:29:44 +0000 (09:29 -0700)
commitd2daa127ed51ac41217962d2b8f9c00be6e9c0d9
treef1f16947d350280b6a76ba08a834a985f184c3a2
parent3f6f7a175ad4cf9a6a3dda72d7f5d122107f4b9e
hsr: fix don't prune the master node from the node_db

Don't prune the master node in the hsr_prune_nodes function.
Neither time_in[HSR_PT_SLAVE_A] nor time_in[HSR_PT_SLAVE_B]
will ever be updated by hsr_register_frame_in for the master port.
Thus, the master node will be repeatedly pruned leading to
repeated packet loss.
This bug never appeared because the hsr_prune_nodes function
was only called once. Since commit 5150b45fd355
("net: hsr: Fix node prune function for forget time expiry") this issue
is fixed unveiling the issue described above.

Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
Tested-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/hsr/hsr_framereg.c