]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amd/display: Split DMUB cmd type into type/subtype
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tue, 12 Nov 2019 20:33:37 +0000 (15:33 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 5 Dec 2019 21:30:35 +0000 (16:30 -0500)
commitd4bbcecb596296834aeafb93008474671c7988cf
tree94f4db3516739b99d88110c4e4617ae6f60cf862
parent75441d9d35f71123933eafa4dd55459403582add
drm/amd/display: Split DMUB cmd type into type/subtype

[Why]
Commands will be considered a stable ABI between driver and firmware.

Commands are also split between DC commands, DAL feature commands,
and VBIOS commands.

Commands are currently not designated to a specific ID and the enum
does not provide a stable ABI.

We currently group all of these into a single command type of 8-bits.
With the stable ABI consideration in mind it's not unreasonable to
run out of command IDs.

For cleaner separation and versioning split the commands into a main
type and a subtype.

[How]
For commands where performance matters (like reg sequences) these
are still considered main commands.

Sub commands will be split by ownership/feature.

Update existing command sequences to reflect new changes.

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/bios/command_table2.c
drivers/gpu/drm/amd/display/dc/dc_helper.c
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd_dal.h [new file with mode: 0644]
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd_vbios.h [new file with mode: 0644]