]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: sierra: use irqsave() in USB's complete callback
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:12 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 13:22:25 +0000 (15:22 +0200)
commitd4bf25b3fc250a5d950691e824bbfa7a732a6608
tree4a8d1040be0ef21cc79580d16494c88187d8f4e4
parente60870012e5a35b1506d7b376fddfb30e9da0b27
USB: serial: sierra: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/sierra.c