]> asedeno.scripts.mit.edu Git - linux.git/commit
MD: fix invalid stored role for a disk
authorShaohua Li <shli@fb.com>
Tue, 2 Oct 2018 01:36:36 +0000 (18:36 -0700)
committerShaohua Li <shli@fb.com>
Tue, 2 Oct 2018 01:36:36 +0000 (18:36 -0700)
commitd595567dc4f0c1d90685ec1e2e296e2cad2643ac
treecad755708fff97a44ddc4b9a6987e16e7854c649
parentee37d7314a32ab6809eacc3389bad0406c69a81f
MD: fix invalid stored role for a disk

If we change the number of array's device after device is removed from array,
then add the device back to array, we can see that device is added as active
role instead of spare which we expected.

Please see the below link for details:
https://marc.info/?l=linux-raid&m=153736982015076&w=2

This is caused by that we prefer to use device's previous role which is
recorded by saved_raid_disk, but we should respect the new number of
conf->raid_disks since it could be changed after device is removed.

Reported-by: Gioh Kim <gi-oh.kim@profitbricks.com>
Tested-by: Gioh Kim <gi-oh.kim@profitbricks.com>
Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/md.c