]> asedeno.scripts.mit.edu Git - linux.git/commit
i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 4 Jan 2019 17:43:27 +0000 (11:43 -0600)
committerPeter Rosin <peda@axentia.se>
Sun, 21 Apr 2019 21:45:08 +0000 (23:45 +0200)
commitd5984d2a312144bedccf32aea2298f8df05bb617
tree1ce3682a9a44b79921a3d700dbc4237b27c72b93
parentf1fb64b04bf414ab04e31ac107bb28137105c5fd
i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Peter Rosin <peda@axentia.se>
drivers/i2c/muxes/i2c-demux-pinctrl.c