]> asedeno.scripts.mit.edu Git - linux.git/commit
net/sched: em_meta: Fix 'meta vlan' to correctly recognize zero VID frames
authorShmulik Ladkani <shmulik.ladkani@gmail.com>
Thu, 20 Oct 2016 21:18:08 +0000 (00:18 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 23 Oct 2016 21:31:25 +0000 (17:31 -0400)
commitd65f2fa680d6f91438461df54c83a331b3a631c9
treeaf192e0efc27f4a65c5e3a0b48927a02c61dcdad
parent1bac938141eea1fb5ef722d1d81ad440b3989ed3
net/sched: em_meta: Fix 'meta vlan' to correctly recognize zero VID frames

META_COLLECTOR int_vlan_tag() assumes that if the accel tag (vlan_tci)
is zero, then no vlan accel tag is present.

This is incorrect for zero VID vlan accel packets, making the following
match fail:
  tc filter add ... basic match 'meta(vlan mask 0xfff eq 0)' ...

Apparently 'int_vlan_tag' was implemented prior VLAN_TAG_PRESENT was
introduced in 05423b2 "vlan: allow null VLAN ID to be used"
(and at time introduced, the 'vlan_tx_tag_get' call in em_meta was not
 adapted).

Fix, testing skb_vlan_tag_present instead of testing skb_vlan_tag_get's
value.

Fixes: 05423b2413 ("vlan: allow null VLAN ID to be used")
Fixes: 1a31f2042e ("netsched: Allow meta match on vlan tag on receive")
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/em_meta.c