]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: sunxi: fix theoretical uninitialized variable access
authorArnd Bergmann <arnd@arndb.de>
Wed, 16 Nov 2016 14:18:18 +0000 (15:18 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 16 Nov 2016 19:53:48 +0000 (20:53 +0100)
commitd8a22212737314cc02692cc90eda7d844fa20257
tree8bb1de334f049cce085715895ca626b6b4b6bbcf
parentd278dae88428d61623590269e5d782264f2ac2f8
pinctrl: sunxi: fix theoretical uninitialized variable access

gcc warns about a  way that it could use an uninitialized variable:

drivers/pinctrl/sunxi/pinctrl-sunxi.c: In function 'sunxi_pinctrl_init':
drivers/pinctrl/sunxi/pinctrl-sunxi.c:1191:8: error: 'best_div' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This cannot really happen except if 'freq' is UINT_MAX and 'clock' is
zero, and both of these are forbidden. To shut up the warning anyway,
this changes the logic to initialize the return code to the first
divider value before looking at the others.

Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncing")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sunxi/pinctrl-sunxi.c