]> asedeno.scripts.mit.edu Git - linux.git/commit
can: j1939: transport: make sure the aborted session will be deactivated only once
authorOleksij Rempel <o.rempel@pengutronix.de>
Thu, 7 Nov 2019 17:46:38 +0000 (18:46 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 13 Nov 2019 09:42:34 +0000 (10:42 +0100)
commitd966635b384b9571a43bd38c61f280c47eb564ad
tree6b4af93485707a092043200d9971f8c5e6400564
parentfd81ebfe7975b9a69494430676d16f7125aac3ee
can: j1939: transport: make sure the aborted session will be deactivated only once

j1939_session_cancel() was modifying session->state without protecting
it by locks and without checking actual state of the session.

This patch moves j1939_tp_set_rxtimeout() into j1939_session_cancel()
and adds the missing locking.

Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
net/can/j1939/transport.c