]> asedeno.scripts.mit.edu Git - linux.git/commit
perf top: Fix wrong hottest instruction highlighted
authorHe Kuang <hekuang@huawei.com>
Sun, 20 Jan 2019 16:05:22 +0000 (00:05 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 21 Jan 2019 14:29:07 +0000 (11:29 -0300)
commitda06d568386877809532e8ec678f4a5e300f0951
treeaca3dd3b896c3881040bb1adfada5812f32cdb4f
parent1497e804d1a6e2bd9107ddf64b0310449f4673eb
perf top: Fix wrong hottest instruction highlighted

The annotation line percentage is compared and inserted into the rbtree,
but the percent field of 'struct annotation_data' is an array, the
comparison result between them is the address difference.

This patch compares the right slot of percent array according to
opts->percent_type and makes things right.

The problem can be reproduced by pressing 'H' in perf top annotation view.
It should highlight the instruction line which has the highest sampling
percentage.

Signed-off-by: He Kuang <hekuang@huawei.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20190120160523.4391-1-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c