]> asedeno.scripts.mit.edu Git - linux.git/commit
cpufreq: conservative: Take limits changes into account properly
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 15 Oct 2018 21:21:05 +0000 (23:21 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 16 Oct 2018 10:34:45 +0000 (12:34 +0200)
commitda5e79bc70b84971d2b3a55fb252e34e51d81d48
treecc8ca2c22530ea1747c97fa671609b961a28920c
parent4b73d334c50dcde25437be52a01e2f5cbf5f9e21
cpufreq: conservative: Take limits changes into account properly

If the policy limits change between invocations of cs_dbs_update(),
the requested frequency value stored in dbs_info may not be updated
and the function may use a stale value of it next time.  Moreover, if
idle periods are takem into account by cs_dbs_update(), the requested
frequency value stored in dbs_info may be below the min policy limit,
which is incorrect.

To fix these problems, always update the requested frequency value
in dbs_info along with the local copy of it when the previous
requested frequency is beyond the policy limits and avoid decreasing
the requested frequency below the min policy limit when taking
idle periods into account.

Fixes: abb6627910a1 (cpufreq: conservative: Fix next frequency selection)
Fixes: 00bfe05889e9 (cpufreq: conservative: Decrease frequency faster for deferred updates)
Reported-by: Waldemar Rymarkiewicz <waldemarx.rymarkiewicz@intel.com>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Waldemar Rymarkiewicz <waldemarx.rymarkiewicz@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq_conservative.c