]> asedeno.scripts.mit.edu Git - linux.git/commit
dm mpath: remove harmful bio-based optimization
authorMike Snitzer <snitzer@redhat.com>
Tue, 26 Nov 2019 15:08:29 +0000 (10:08 -0500)
committerMike Snitzer <snitzer@redhat.com>
Tue, 26 Nov 2019 15:22:46 +0000 (10:22 -0500)
commitdbaf971c9cdf10843071a60dcafc1aaab3162354
treefaaf05b43578af2d2aa7331512664b63e670b109
parentf612b2132db529feac4f965f28a1b9258ea7c22b
dm mpath: remove harmful bio-based optimization

Removes the branching for edge-case where no SCSI device handler
exists.  The __map_bio_fast() method was far too limited, by only
selecting a new pathgroup or path IFF there was a path failure, fix this
be eliminating it in favor of __map_bio().  __map_bio()'s extra SCSI
device handler specific MPATHF_PG_INIT_REQUIRED test is not in the fast
path anyway.

This change restores full path selector functionality for bio-based
configurations that don't haave a SCSI device handler.  But it should be
noted that the path selectors do have an impact on performance for
certain networks that are extremely fast (and don't require frequent
switching).

Fixes: 8d47e65948dd ("dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks")
Cc: stable@vger.kernel.org
Reported-by: Drew Hastings <dhastings@crucialwebhost.com>
Suggested-by: Martin Wilck <mwilck@suse.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c