]> asedeno.scripts.mit.edu Git - linux.git/commit
MIPS: Guard against any partial write attempt with PTRACE_SETREGSET
authorMaciej W. Rozycki <macro@mips.com>
Mon, 11 Dec 2017 22:52:15 +0000 (22:52 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Tue, 12 Dec 2017 18:11:53 +0000 (19:11 +0100)
commitdc24d0edf33c3e15099688b6bbdf7bdc24bf6e91
treed81454989e98c8925d871d8decd27aca3a0597af
parenta03fe72572c12e98f4173f8a535f32468e48b6ec
MIPS: Guard against any partial write attempt with PTRACE_SETREGSET

Complement commit d614fd58a283 ("mips/ptrace: Preserve previous
registers for short regset write") and ensure that no partial register
write attempt is made with PTRACE_SETREGSET, as we do not preinitialize
any temporaries used to hold incoming register data and consequently
random data could be written.

It is the responsibility of the caller, such as `ptrace_regset', to
arrange for writes to span whole registers only, so here we only assert
that it has indeed happened.

Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset")
Cc: James Hogan <james.hogan@mips.com>
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Alex Smith <alex@alex-smith.me.uk>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v3.15+
Patchwork: https://patchwork.linux-mips.org/patch/17926/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/kernel/ptrace.c