]> asedeno.scripts.mit.edu Git - linux.git/commit
acpi, numa: fix pxm to online numa node associations
authorDan Williams <dan.j.williams@intel.com>
Fri, 16 Mar 2018 02:49:14 +0000 (19:49 -0700)
committerDan Williams <dan.j.williams@intel.com>
Fri, 16 Mar 2018 02:49:14 +0000 (19:49 -0700)
commitdc9e0a9347e932e3fd3cd03e7ff241022ed6ea8a
treebdadbe546992ab275e1eb620f5411ace477cf5a5
parenta7e6c7015bf3e0cb467a2f6c0e1de985ee1a0ecb
acpi, numa: fix pxm to online numa node associations

Commit 99759869faf1 "acpi: Add acpi_map_pxm_to_online_node()" added
support for mapping a given proximity to its nearest, by SLIT distance,
online node. However, it sometimes returns unexpected results due to the
fact that it switches from comparing the PXM node to the last node that
was closer than the current max.

    for_each_online_node(n) {
            dist = node_distance(node, n);
            if (dist < min_dist) {
                    min_dist = dist;
                    node = n; <---- from this point we're using the
      wrong node for node_distance()

Fixes: 99759869faf1 ("acpi: Add acpi_map_pxm_to_online_node()")
Cc: <stable@vger.kernel.org>
Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/acpi/numa.c