]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915/gvt: ensure -ve return value is handled correctly
authorColin Ian King <colin.king@canonical.com>
Tue, 19 Sep 2017 15:55:34 +0000 (16:55 +0100)
committerJani Nikula <jani.nikula@intel.com>
Tue, 21 Nov 2017 09:39:43 +0000 (11:39 +0200)
commitdcd1d8302a06b0a0e5d6f9b6851fa4a5579e79b0
tree97198d5f2aa431477d6aef0dd433e5cb4d3f602d
parent294cf1af8cf2eb0d1eced377fdfb9a2d3f0e8b42
drm/i915/gvt: ensure -ve return value is handled correctly

An earlier fix changed the return type from find_bb_size however the
integer return is being assigned to a unsigned int so the -ve error
check will never be detected. Make bb_size an int to fix this.

Detected by CoverityScan CID#1456886 ("Unsigned compared against 0")

Fixes: 1e3197d6ad73 ("drm/i915/gvt: Refine error handling for perform_bb_shadow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
(cherry picked from commit 24f8a29af4afe7c53e08f4afa0c3fa9eb3791b89)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gvt/cmd_parser.c