]> asedeno.scripts.mit.edu Git - linux.git/commit
Drivers: hv: kvp: Use MAX_ADAPTER_ID_SIZE for translating adapter id
authorAlex Ng <alexng@messages.microsoft.com>
Sun, 6 Aug 2017 20:12:56 +0000 (13:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Aug 2017 16:14:43 +0000 (09:14 -0700)
commitddce54b6a95ed5ee3011b4771fda69c2d8a6d538
treea48be6817b6de2ae570db9c312325a6be6575c83
parentc548f3957efa57b6f1a1f4c90013232f6f488682
Drivers: hv: kvp: Use MAX_ADAPTER_ID_SIZE for translating adapter id

There's a bug which passes the output buffer size as MAX_IP_ADDR_SIZE,
when converting the adapter_id field to UTF16. This is much larger than
the actual size (MAX_ADAPTER_ID_SIZE). Fix this by passing the proper
size.

Fortunately, the translation is limited by the length of the input. This
explains why we haven't seen output buffer overflow conditions.

Signed-off-by: Alex Ng <alexng@messages.microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hv/hv_kvp.c