]> asedeno.scripts.mit.edu Git - linux.git/commit
s390/disassembler: remove confusing code
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Fri, 17 Nov 2017 08:50:40 +0000 (09:50 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Mon, 20 Nov 2017 07:51:02 +0000 (08:51 +0100)
commitde35089cc82c33f8be1dec5a0c3d7a05cf91720d
treee47b55158cd1458151ad59f4171856810fd561bb
parent3241d3eb7d9bb7a134bedf49db196cf98b58834d
s390/disassembler: remove confusing code

When searching the opcode offset table within find_insn() the check
"entry->opcode == 0" was intended to clarify that 1-byte opcodes, the
first one being 0, are special.

However there is no mnemonic for an illegal opcode starting with 0.
Therefore there is also no opcode offset table entry that matches,
which again means that the check never is true. Therefore just remove
the confusing check, and add a comment which hopefully explains how
this works.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/kernel/dis.c