]> asedeno.scripts.mit.edu Git - linux.git/commit
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
authorPaolo Abeni <pabeni@redhat.com>
Thu, 15 Feb 2018 15:59:49 +0000 (16:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Feb 2018 20:46:15 +0000 (15:46 -0500)
commitdfec091439bb2acf763497cfc58f2bdfc67c56b7
tree2bb3c073bec00841426c513d65b67e4b030b8e86
parent7dcf688d4c78a18ba9538b2bf1b11dc7a43fe9be
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock

After commit 3f34cfae1238 ("netfilter: on sockopt() acquire sock lock
only in the required scope"), the caller of nf_{get/set}sockopt() must
not hold any lock, but, in such changeset, I forgot to cope with DECnet.

This commit addresses the issue moving the nf call outside the lock,
in the dn_{get,set}sockopt() with the same schema currently used by
ipv4 and ipv6. Also moves the unhandled sockopts of the end of the main
switch statements, to improve code readability.

Reported-by: Petr Vandrovec <petr@vandrovec.name>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=198791#c2
Fixes: 3f34cfae1238 ("netfilter: on sockopt() acquire sock lock only in the required scope")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/decnet/af_decnet.c