]> asedeno.scripts.mit.edu Git - linux.git/commit
staging: pi433: replace INVALID_PARAM macro with inline code
authorMarcin Ciupak <marcin.s.ciupak@gmail.com>
Thu, 17 Aug 2017 15:00:17 +0000 (17:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Aug 2017 22:57:15 +0000 (15:57 -0700)
commite221b2b11bdc3f5b0a42165422335044c472964b
tree96f934961bda321dcbd428a5d9cdc68b9f1a4fc9
parentf2aee92d1865d8ff49fa7d715be638c849c650cf
staging: pi433: replace INVALID_PARAM macro with inline code

The following macro:
\#define INVALID_PARAM
{ \
                dev_dbg(&spi->dev, "set: illegal input param"); \
                return -EINVAL; \
        }
affects control flow by having return statement. This is against
Linux Kernel Coding Style and should be avoided and therefore
this macro is replaced by inline code.

Additionally following 3 minor issues:

ERROR: code indent should use tabs where possible
ERROR: spaces required around that '!=' (ctx:VxV)
ERROR: space prohibited before that close parenthesis ')'

were fiexed inline.

Signed-off-by: Marcin Ciupak <marcin.s.ciupak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/pi433/rf69.c