]> asedeno.scripts.mit.edu Git - linux.git/commit
drm: rcar-du: Don't set connector DPMS property
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 15 Aug 2017 12:36:19 +0000 (15:36 +0300)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 4 Dec 2017 11:04:11 +0000 (13:04 +0200)
commite2f930aaa3519865bbdfa1a37d4974a717c1fa09
tree546e2f2717c6c4056bf0673365645f17de59f2a8
parentcdd90700157293dc7cb67d932b4f2fc44bd2a623
drm: rcar-du: Don't set connector DPMS property

Since commit 4a97a3da420b ("drm: Don't update property values for atomic
drivers") atomic drivers must not update property values as properties
are read from the state instead. To catch remaining users, the
drm_object_property_set_value() function now throws a warning when
called by atomic drivers on non-immutable properties, and we hit that
warning when creating connectors.

The easy fix is to just remove the drm_object_property_set_value() as it
is used here to set the initial value of the connector's DPMS property
to OFF. The DPMS property applies on top of the connector's state crtc
pointer (initialized to NULL) that is the main connector on/off control,
and should thus default to ON.

Fixes: 4a97a3da420b ("drm: Don't update property values for atomic drivers")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c