]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: ch341: fix type promotion bug in ch341_control_in()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 4 Jul 2018 09:29:38 +0000 (12:29 +0300)
committerJohan Hovold <johan@kernel.org>
Wed, 4 Jul 2018 13:40:54 +0000 (15:40 +0200)
commite33eab9ded328ccc14308afa51b5be7cbe78d30b
tree6bfa33296602bd3e3a1b72e1142c25b69fe1063a
parent021c91791a5e7e85c567452f1be3e4c2c6cb6063
USB: serial: ch341: fix type promotion bug in ch341_control_in()

The "r" variable is an int and "bufsize" is an unsigned int so the
comparison is type promoted to unsigned.  If usb_control_msg() returns a
negative that is treated as a high positive value and the error handling
doesn't work.

Fixes: 2d5a9c72d0c4 ("USB: serial: ch341: fix control-message error handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ch341.c