]> asedeno.scripts.mit.edu Git - linux.git/commit
arm: dts: meson: Fix IRQ trigger type for macirq
authorCarlo Caione <ccaione@baylibre.com>
Fri, 7 Dec 2018 10:52:31 +0000 (10:52 +0000)
committerKevin Hilman <khilman@baylibre.com>
Fri, 11 Jan 2019 00:20:15 +0000 (16:20 -0800)
commite35e26b26e955c53e61c154ba26b9bb15da6b858
treeb0d4570d16f0c722c50a75df5d4f234c66685130
parent19a220dd1e8a1b1d8e5e2f8f4a25313c4b02d527
arm: dts: meson: Fix IRQ trigger type for macirq

A long running stress test on a custom board shipping an AXG SoCs and a
Realtek RTL8211F PHY revealed that after a few hours the connection
speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time
the 'macirq' (eth0) IRQ would stop being triggered at all and as
consequence the GMAC IRQs never ACKed.

After a painful investigation the problem seemed to be due to a wrong
defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of
EDGE_RISING.

The change in the macirq IRQ type also solved another long standing
issue affecting this SoC/PHY where EEE was causing the network
connection to die after stressing it with iperf3 (even though much
sooner). It's now possible to remove the 'eee-broken-1000t' quirk as
well.

Fixes: 9c15795a4f96 ("ARM: dts: meson8b-odroidc1: ethernet support")
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
arch/arm/boot/dts/meson.dtsi
arch/arm/boot/dts/meson8b-odroidc1.dts