]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/sun4i: Fix polarity configuration for DW HDMI PHY
authorJernej Skrabec <jernej.skrabec@siol.net>
Thu, 1 Mar 2018 21:34:35 +0000 (22:34 +0100)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Fri, 2 Mar 2018 07:45:22 +0000 (08:45 +0100)
commite420ccd66d36e4ac2035620286495ce13a40b7f7
tree7db46e447eabb74fd05b0a3df215fff3fd027b74
parente679f4a13f0fd1da4ef5b9c59c78404cd421c61b
drm/sun4i: Fix polarity configuration for DW HDMI PHY

Current polarity configuration code is cleary wrong since it compares
same flag two times. However, even if flag name is fixed, it won't work
well for resolutions which have one polarity positive and another
negative.

Fix that by properly set each bit according to each polarity. Since
those two bits are not described in any documentation, relationships
were obtained by experimentation.

Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180301213442.16677-10-jernej.skrabec@siol.net
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c