]> asedeno.scripts.mit.edu Git - linux.git/commit
rtc: pm8xxx: fix unintended sign extension
authorColin Ian King <colin.king@canonical.com>
Wed, 6 Feb 2019 10:31:02 +0000 (10:31 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 8 Feb 2019 08:30:13 +0000 (09:30 +0100)
commite42280886018c6f77f0a90190f7cba344b0df3e0
treecc8d3ce9b198354a00ca1335d2145a2f30f465e4
parentfb0b322537a831b5b0cb948c56f8f958ce493d3a
rtc: pm8xxx: fix unintended sign extension

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#1309693 ("Unintended sign extension")

Fixes: 9a9a54ad7aa2 ("drivers/rtc: add support for Qualcomm PMIC8xxx RTC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pm8xxx.c