]> asedeno.scripts.mit.edu Git - linux.git/commit
tpm: Restore functionality to xen vtpm driver.
authorDr. Greg Wettstein <greg@wind.enjellic.com>
Mon, 17 Sep 2018 22:53:33 +0000 (18:53 -0400)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fri, 5 Oct 2018 10:47:34 +0000 (13:47 +0300)
commite487a0f52301293152a6f8c4e217f2a11dd808e3
tree07d7b4bed9d8f9c7a24f8a88cb29364048c55cd6
parent9e1b74a63f7760b525295161fc608b19b8ee19c4
tpm: Restore functionality to xen vtpm driver.

Functionality of the xen-tpmfront driver was lost secondary to
the introduction of xenbus multi-page support in commit ccc9d90a9a8b
("xenbus_client: Extend interface to support multi-page ring").

In this commit pointer to location of where the shared page address
is stored was being passed to the xenbus_grant_ring() function rather
then the address of the shared page itself. This resulted in a situation
where the driver would attach to the vtpm-stubdom but any attempt
to send a command to the stub domain would timeout.

A diagnostic finding for this regression is the following error
message being generated when the xen-tpmfront driver probes for a
device:

<3>vtpm vtpm-0: tpm_transmit: tpm_send: error -62

<3>vtpm vtpm-0: A TPM error (-62) occurred attempting to determine
the timeouts

This fix is relevant to all kernels from 4.1 forward which is the
release in which multi-page xenbus support was introduced.

Daniel De Graaf formulated the fix by code inspection after the
regression point was located.

Fixes: ccc9d90a9a8b ("xenbus_client: Extend interface to support multi-page ring")
Signed-off-by: Dr. Greg Wettstein <greg@enjellic.com>
[boris: Updated commit message, added Fixes tag]
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: stable@vger.kernel.org # v4.1+
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/xen-tpmfront.c