]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: sierra: fix potential deadlock at close
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:11 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 13:12:49 +0000 (15:12 +0200)
commite60870012e5a35b1506d7b376fddfb30e9da0b27
tree98cc954a1e570a9aa51d4f492c7cf87aa7a1a903
parent2ba02c8dd063c4396111629e96dec5a3f231f995
USB: serial: sierra: fix potential deadlock at close

The portdata spinlock can be taken in interrupt context (via
sierra_outdat_callback()).
Disable interrupts when taking the portdata spinlock when discarding
deferred URBs during close to prevent a possible deadlock.

Fixes: 014333f77c0b ("USB: sierra: fix urb and memory leak on disconnect")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
[ johan: amend commit message and add fixes and stable tags ]
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/sierra.c