]> asedeno.scripts.mit.edu Git - linux.git/commit
perf annotate browser: Fixup vertical line separating metrics from instructions
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 5 Apr 2018 14:35:32 +0000 (11:35 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 5 Apr 2018 14:50:44 +0000 (11:50 -0300)
commite726c8511c052ba40dc943517b54011e42c2dfa3
tree7f6adc58fbff29b51ab372e48c784d5d5d1a4382
parentc0459a092509f9c2ff91cc070cd2645d38e7cf7b
perf annotate browser: Fixup vertical line separating metrics from instructions

Now that we can have extra title lines we should use ui_browser->rows
and not ->height when drawing lines, as it will use ui_browser__gotorc()
and that will take the extra title lines into account, which was causing
an off by one at the end of the vertical line drawn by
__ui_browser__vline(), fix it.

The visual effect was that the last line, with status messages, was
being overwritten by the vertical line, looking like:

Press 'h' for help on│key bindings

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the hists browser")
Link: https://lkml.kernel.org/n/tip-08y1ln3xjn76zvizz1i1dsvn@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c